https://bugzilla.redhat.com/show_bug.cgi?id=851890 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok b111a2ea36b6fea4603d63e4dc252092 mate-window-manager-1.4.0.tar.xz licensing: NOT ok 1. according to licensecheck, all sources are GPL (v2 or later) (with incorrect FSF address) so MUST use License: GPLv2+ scriptlets: ok 2. -devel SHOULD drop Requires: %{name}%{?_isa} = %{version}-%{release} depending on -libs is enough 3. main pkg MUST Requires: %{name}-libs%{?_isa} = %{version}-%{release} macros: not ok 4. MUST not use undefined %{po_package} macro, either define it, or just use %{name} in place of it 5. MUST own theme parent dirs, instead of: %{_datadir}/themes/ClearlooksRe/metacity-1/ %{_datadir}/themes/Dopple-Left/metacity-1/ %{_datadir}/themes/Dopple/metacity-1/ %{_datadir}/themes/DustBlue/metacity-1/ %{_datadir}/themes/Spidey-Left/metacity-1 %{_datadir}/themes/Spidey/metacity-1/ %{_datadir}/themes/Splint-Left/metacity-1/ %{_datadir}/themes/Splint/metacity-1/ %{_datadir}/themes/WinMe/metacity-1/ %{_datadir}/themes/eOS/metacity-1/ use %{_datadir}/themes/ClearlooksRe/ %{_datadir}/themes/Dopple-Left/ %{_datadir}/themes/Dopple/ %{_datadir}/themes/DustBlue/ %{_datadir}/themes/Spidey-Left/ %{_datadir}/themes/Spidey/ %{_datadir}/themes/Splint-Left/ %{_datadir}/themes/Splint/ %{_datadir}/themes/WinMe/ %{_datadir}/themes/eOS/ or even just %{_datadir}/themes/* -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review