https://bugzilla.redhat.com/show_bug.cgi?id=851889 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. MUST: simplify %files devel includes to just %{_includedir}/libmate-2.0/ so the parent and all subdirs are owned too. 2. MUST move %{_datadir}/gtk-doc/html/libmate/ to -devel, these items are usually developer/api documentation (unless you have reason to believe otherwise). 3. SHOULD remove %pre /sbin/ldconfig (not needed here, just %post, %postun) 4. SHOULD consider simplifying mate-conf-related scriptlets. I believe it's possible to list them all at once, instead of one per line, but I'll leave that to your discretion. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review