https://bugzilla.redhat.com/show_bug.cgi?id=851859 --- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> --- Hi Erik, your spec file looks almost fine now. There are a still a few things to be addressed, though: - When compiling C or C++ code, you must ensure that Fedora's %{optflags} are applied (http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags). As you can see in the logs of your koji build log, the C++ sources are built without them. Only the C file (physfsrwops.c) is compiled properly. - The tarball contains a copy of the enet library. As far as I can see, it's not used. However, you must remove the enet folder in the %prep section to ensure that the library code is not linked. Building packages with bundled third-party libraries is not allowed in Fedora. Such libraries must be packaged separately. http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries - Please replace "%files -f mana.lang" with "%files -f %{name}.lang". - Finally, increase the Release number and add a corresponding %changlog entry every time you provide a new revision of your packages. The changelog should document all changes that have been applied to the preceding revision. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review