https://bugzilla.redhat.com/show_bug.cgi?id=754437 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- $ rpmlint mingw-libvirt-glib.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-libvirt-glib-0.0.8-1.fc17.src.rpm mingw-libvirt-glib.src: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw-libvirt-glib.src: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw-libvirt-glib.src: W: strange-permission libvirt-glib-0.0.8.tar.gz 0444L 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint mingw32-libvirt-glib-0.0.8-1.fc17.noarch.rpm mingw32-libvirt-gconfig-0.0.8-1.fc17.noarch.rpm mingw32-libvirt-gobject-0.0.8-1.fc17.noarch.rpm mingw64-libvirt-glib-0.0.8-1.fc17.noarch.rpm mingw64-libvirt-gconfig-0.0.8-1.fc17.noarch.rpm mingw64-libvirt-gobject-0.0.8-1.fc17.noarch.rpm mingw32-libvirt-glib.noarch: W: spelling-error Summary(en_US) gconfig -> configure mingw32-libvirt-glib.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw32-libvirt-glib.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw32-libvirt-gconfig.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw32-libvirt-gconfig.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw32-libvirt-gconfig.noarch: W: no-documentation mingw32-libvirt-gobject.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw32-libvirt-gobject.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw32-libvirt-gobject.noarch: W: no-documentation mingw64-libvirt-glib.noarch: W: spelling-error Summary(en_US) gconfig -> configure mingw64-libvirt-glib.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw64-libvirt-glib.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw64-libvirt-gconfig.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw64-libvirt-gconfig.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw64-libvirt-gconfig.noarch: W: no-documentation mingw64-libvirt-gobject.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization mingw64-libvirt-gobject.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization mingw64-libvirt-gobject.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 18 warnings. $ rpm --query --requires mingw32-libvirt-glib mingw32(kernel32.dll) mingw32(libglib-2.0-0.dll) mingw32(libvirt-0.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-libvirt-gconfig mingw32(kernel32.dll) mingw32(libglib-2.0-0.dll) mingw32(libgobject-2.0-0.dll) mingw32(libxml2-2.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-libvirt-gobject mingw32(kernel32.dll) mingw32(libgio-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libgobject-2.0-0.dll) mingw32(libvirt-0.dll) mingw32(libvirt-gconfig-1.0-0.dll) mingw32(libvirt-glib-1.0-0.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-libvirt-glib mingw64(kernel32.dll) mingw64(libglib-2.0-0.dll) mingw64(libvirt-0.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-libvirt-gconfig mingw64(kernel32.dll) mingw64(libglib-2.0-0.dll) mingw64(libgobject-2.0-0.dll) mingw64(libxml2-2.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-libvirt-gobject mingw64(kernel32.dll) mingw64(libgio-2.0-0.dll) mingw64(libglib-2.0-0.dll) mingw64(libgobject-2.0-0.dll) mingw64(libvirt-0.dll) mingw64(libvirt-gconfig-1.0-0.dll) mingw64(libvirt-glib-1.0-0.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-libvirt-glib mingw32(libvirt-glib-1.0-0.dll) mingw32-libvirt-glib = 0.0.8-1.fc17 $ rpm --query --provides mingw32-libvirt-gconfig mingw32(libvirt-gconfig-1.0-0.dll) mingw32-libvirt-gconfig = 0.0.8-1.fc17 $ rpm --query --provides mingw32-libvirt-gobject mingw32(libvirt-gobject-1.0-0.dll) mingw32-libvirt-gobject = 0.0.8-1.fc17 $ rpm --query --provides mingw64-libvirt-glib mingw64(libvirt-glib-1.0-0.dll) mingw64-libvirt-glib = 0.0.8-1.fc17 $ rpm --query --provides mingw64-libvirt-gconfig mingw64(libvirt-gconfig-1.0-0.dll) mingw64-libvirt-gconfig = 0.0.8-1.fc17 $ rpm --query --provides mingw64-libvirt-gobject mingw64(libvirt-gobject-1.0-0.dll) mingw64-libvirt-gobject = 0.0.8-1.fc17 $ wget --quiet ftp://libvirt.org/libvirt/glib/libvirt-glib-0.0.8.tar.gz -O - | md5sum cc0913fdf1011558e81e7de4b00c7d1f - $ md5sum libvirt-glib-0.0.8.tar.gz cc0913fdf1011558e81e7de4b00c7d1f libvirt-glib-0.0.8.tar.gz + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [!] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal The rpmlint warning strange-permission looks harmless and will probably disappear automatically when uploading the tarball to the Fedora infrastructure The BuildRoot and %defattr tags are unneeded these days and can be removed The quotes in the %mingw_make_install call are also unneeded and can be removed The libtool .la files are also unneeded and can be removed Please fix these minor issues before importing in Fedora ======================================================== The package mingw-libvirt-glib is APPROVED by epienbro ======================================================== -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review