https://bugzilla.redhat.com/show_bug.cgi?id=851859 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> --- Some further quick notes: - The Release number should start with 1, and needs to be followed by %{?dist}: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag - You can drop the BuildRoot field. It's no longer required in Fedora. http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag - Check the validity of the .desktop file with desktop-file-validate (in the %install section). http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage - replace "mana" with %{name} in %find_lang and %files - You can also drop the %defattr line. http://fedoraproject.org/wiki/PackagingGuidelines#File_Permissions -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review