https://bugzilla.redhat.com/show_bug.cgi?id=830418 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #9 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> --- Two minors: - you should append one comment about the patch (e.g. # ensure django-1.4 compatibility) (or so - some more serious: (from files section): %{python_sitelib}/avatar/management/* %{python_sitelib}/avatar/media/* %{python_sitelib}/avatar/templates/* %{python_sitelib}/avatar/templatetags/* Those lines include all files in those directories, but not those dirs themself: (eg): [mrunge@turing results]$ rpm -qlp python-django-avatar-2.0a1-2.20120609git097ed8.fc19.noarch.rpm | grep templatetags /usr/lib/python2.7/site-packages/avatar/templatetags/__init__.py /usr/lib/python2.7/site-packages/avatar/templatetags/__init__.pyc /usr/lib/python2.7/site-packages/avatar/templatetags/__init__.pyo /usr/lib/python2.7/site-packages/avatar/templatetags/avatar_tags.py /usr/lib/python2.7/site-packages/avatar/templatetags/avatar_tags.pyc /usr/lib/python2.7/site-packages/avatar/templatetags/avatar_tags.pyo note: the templatetags directory is not listed. I'm sure, you'll correct that during import, won't you? Package approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review