[Bug 833622] Review Request: mingw-gmp - Cross-compiled GNU arbitrary precision library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833622

Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |mingw-gmp

--- Comment #9 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> ---
Please set the alias to the package name, as is customary for mingw packages,
then I'd have found your review request...

$ rpmlint mingw-gmp.spec 
mingw-gmp.spec:86: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line
86)

BR mingw32/64-gcc-c++ is missing

What exactly are source2 and source3 used for?

Your spec file seems to be derived from the native spec file - it would be nice
to acknowledge this eg. in the changelog.

Can you elaborate on why you're unconfortable shipping -static subpackages? It
doesn't seem hard to do (see my spec file
http://sailer.fedorapeople.org/mingw-gmp.spec), and apparently some users
request it...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]