https://bugzilla.redhat.com/show_bug.cgi?id=851641 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> --- Drop the Requires line. rpmbuild is able to figure that out. qt3-devel would have been wrong anyway. As far as I can see, this package bundles code from at least Argyll and wxwidgets which is not allowed. Some snapshot of SCons is included as well. What is Patch0 good for? Please put a comment in the spec file and refer to an upstream ticket, if possible. Add sRGB_profile_License and KNOWN_BUGS to the doc macro. """ %{_datadir}/%{name}/data/pics/* %{_datadir}/%{name}/data/profiles/* %{_datadir}/%{name}/data/template/* """ Using this syntax, you don't own {_datadir}/%{name}. I'd just replace those three lines with: {_datadir}/%{name} Please use the name macro for the patch names. I also suggest to use it for the icon and desktop file. I personally consider "open source" not worth mentioning and only bloating description and summary, because everything in Fedora is Free Software. Please inform upstream about the wrong postal address of the FSF. The actual license is GPLv2+, by the way. You can find out easily using "licensecheck". The build doesn't use Fedora's compiler flags. Using them will also produce a useful debuginfo package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review