https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #10 from Shakthi Kannan <shakthimaan@xxxxxxxxx> --- Thanks for the review. I have made the following changes: - Use README in main package and DOC in devel package - chmod a-x on SRC/qselect.c - Remove -latlas linking in prep section - Added Patch comments - Use name RPM macro in patch name Will inform upstream about not using exit in the library. I would like the package to be made available for EPEL5, and hence have not removed "rm -rf %{buildroot}" from %install, and %defattr from both %files sections. I haven't added the testing check, because, it uses the static library, which we don't build now. Updated: SPEC: http://shakthimaan.fedorapeople.org/SPECS/SuperLU.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/SuperLU-4.3-3.fc16.src.rpm Successful Koji builds for F16, F17 and F18 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=4421670 http://koji.fedoraproject.org/koji/taskinfo?taskID=4421679 http://koji.fedoraproject.org/koji/taskinfo?taskID=4421684 $ rpmlint SuperLU.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SuperLU-4.3-3.fc16.src.rpm SuperLU.src: W: spelling-error %description -l en_US preordered -> reordered, p reordered, prerecorded SuperLU.src: W: spelling-error %description -l en_US preordering -> reordering, p reordering, preordaining 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint SuperLU-4.3-3.fc16.x86_64.rpm SuperLU.x86_64: W: spelling-error %description -l en_US preordered -> reordered, p reordered, prerecorded SuperLU.x86_64: W: spelling-error %description -l en_US preordering -> reordering, p reordering, preordaining SuperLU.x86_64: W: shared-lib-calls-exit /usr/lib64/libsuperlu.so.4.3 exit@GLIBC_2.2.5 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint SuperLU-devel-4.3-3.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review