Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gnome-terminal https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225839 reza@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|reza@xxxxxxxxxxxxx |besfahbo@xxxxxxxxxx CC| |reza@xxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From reza@xxxxxxxxxxxxx 2007-02-12 12:32 EST ------- Output of src.rpm rpmlint: W: gnome-terminal mixed-use-of-spaces-and-tabs (spaces: line 75, tab: line 92) Output of i386.rpm rpmlint: W: gnome-terminal non-conffile-in-etc /etc/gconf/schemas/gnome-terminal.schemas (Respecting http://lists.debian.org/debian-gtk-gnome/2004/01/msg00020.html , We can ignore this warning.) RPM name is OK. spec file name is OK. License: GPL. [OK] Source gnome-terminal-2.17.90.tar.bz2 is the same as upstream. Builds fine in mock for i386. Comparing package Requires and BuildRequires with configure.in : configure.in spec ----------------------------- ----------------------------- GTK_REQUIRED=2.10.0 %define gtk2_version 2.6.0 VTE_REQUIRED=0.13.4 %define vte_version 0.12.0-2 GNOMEVFS_REQUIRED=2.4 ? libglade-2.0 ? libgnomeui-2.0 %define libgnomeui_version 2.3.0 pangoxft >= 1.1.1 %define pango_version 1.8.0 GConf2 >= 2.14 is repeated three times, could be defined as a macro. There is no URL of source tarball. There are 3 patches and one .po file in cvs but just one is applied. They should be removed. Configure flags are not documented. (--with-widget=vte --disable-scrollkeeper) Parallel make flag is not used. %makeinstall is used instead of 'make install DESTDIR=%{buildroot}'. [BLOCKER] "gnome" is used as vendor for desktop-file-install. However that was "gnome" for FC4 SRPM too, and vendor_id should be constant for the life of a package. So it's ok. 'rm -r $RPM_BUILD_ROOT/var/scrollkeeper' has not any comment/document. (Does it have effect on %find_lang ?) Files list: %{_datadir}/gnome/help/gnome-terminal *** No dependency to owner of %{_datadir}/gnome/help/ nor %{_datadir}/gnome/ [BLOCKER] %{_sysconfdir}/gconf/schemas/gnome-terminal.schemas *** No dependency to owner of %{_sysconfdir}/gconf/schemas/ nor %{_sysconfdir}/gconf/ [BLOCKER] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review