[Bug 844740] Review Request: qmmp-plugin-pack - A set of extra plugins for Qmmp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844740

--- Comment #6 from Karel Volný <kvolny@xxxxxxxxxx> ---
(In reply to comment #5)
> [x] MUST: A package must own all directories that it creates. If it does not
> create a directory that it uses, then it should require a package which does
> create that directory.
>     Your package doesn't own the folders %{_libdir}/qmmp/Input/ and
>     %{_libdir}/qmmp/Ui/. Just remove the trailing *.so from each line
>     to fix this.
> 
> You just have to fix the folder ownerships.

there is indirect dependency:

$ rpm -q --requires -p qmmp-plugin-pack-0.6.2-1.fc19.x86_64.rpm 
libQtCore.so.4()(64bit)  
libQtGui.so.4()(64bit)  
libQtNetwork.so.4()(64bit)  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.14)(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
libc.so.6(GLIBC_2.3.4)(64bit)  
libc.so.6(GLIBC_2.4)(64bit)  
libgcc_s.so.1()(64bit)  
libgcc_s.so.1(GCC_3.0)(64bit)  
libm.so.6()(64bit)  
libqmmp.so.0()(64bit)  
libqmmpui.so.0()(64bit)  
libstdc++.so.6()(64bit)  
libstdc++.so.6(CXXABI_1.3)(64bit)  
libstdc++.so.6(GLIBCXX_3.4)(64bit)  
libtag.so.1()(64bit)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)  
rpmlib(PayloadIsXz) <= 5.2-1


libqmmp and libqmmpui are provided by qmmp, which owns these directories

... hope this is sufficient?


> Moreover, if you not intend to update your el5 package of qmmp to v0.6.2 or
> newer, please remove BuildRoot, the initial cleaning of %{buildroot} in
> %install, the %clean section and the %defattr line from %files. Do this anyway
> when importing your spec to the Git repo for non-el5 branches.

ok; I've just used the template and I've missed that half of it is obsolete ...

no, I don't plan to push this into EL5

thanks for the review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]