[Bug 850679] Review Request: rubygem-pdf-reader - Ruby library to parse PDF files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=850679

--- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
- Please run the upstream specs in %check section.
- Did you try building the package on RHEL? It seems to me that you have no
BuildRequires for RHEL, therefore it will not build (on RHEL, you should BR:
rubygems, at least).
- You should probably make the scripts in examples executable (some already
are, but some are not).
- You should fix the Ascii85 gem dependency. The gemspec says

s.add_runtime_dependency(%q<Ascii85>, ["~> 1.0.0"])

So you should also use Requires: rubygem(Ascii85) < 1.1

Otherwise the package looks good. Please post the updated spec and srpm, before
I can approve it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]