[Bug 830418] Review Request: python-django-avatar - A reusable django application for handling user avatars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=830418

--- Comment #7 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> ---
OK, 

following https://help.github.com/articles/merging-a-pull-request
you need to get 
https://github.com/ericflo/django-avatar/pull/37.patch
save it e.g as django-avatar-django-1.4.patch

include it:
# support django-1.4 according to
# https://github.com/ericflo/django-avatar/pull/37
Patch0: django-avatar-django-1.4.patch
...

(append the term ".patch" to the pull request)
and apply that patch to the code:
%patch0 -p1

Another thing, I've noticed:
During build, some warnings appear:
warning: File listed twice:
/usr/lib/python2.7/site-packages/avatar/locale/de/LC_MESSAGES/django.mo
warning: File listed twice:
/usr/lib/python2.7/site-packages/avatar/locale/fr/LC_MESSAGES/django.mo
warning: File listed twice:
/usr/lib/python2.7/site-packages/avatar/locale/pt_BR/LC_MESSAGES/django.mo

You need to take care of that. In the main django-package, we list all files
separately. That's not fashionable, but surely does it. If you find another
solution, I'm fine with it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]