[Bug 846744] Review Request: libmate - MATE base library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=846744

--- Comment #6 from Dan Mashal <dan.mashal@xxxxxxxxx> ---
Build requires should be as follows:

mate-common
mate-conf-devel
mate-vfs
libmatecomponent-devel
libcanberra-devel
GConf2 (unless we are using mateconf here?)

==============================================================================

Build/install sections should look like this:

%build
%configure -disable-static --disable-schemas --disable-esd
make %{?_smp_mflags} V=1

===========================================================================

Needs to be here for schemas:

%pre
%gconf_schema_prepare *.schemas

===========================================================================

%install
export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1
make DESTDIR=%{buildroot} install
%find_lang %{name}
rm -rf %{buildroot}/%{_libdir}/matecomponent/monikers/*.la

===========================================================================

Please own the proper dirs:

%{_datadir}/gtk-doc/html/libmate/
%{_includedir}/libmate-2.0/
{_datadir}/mate-background-properties/mate-default.xml


sysconfdir should look like this: pretty simple.

Please change %config directive to the following:

%config(noreplace) %{_sysconfdir}/sound/events/mate.soundlist
%config(noreplace) %{_sysconfdir}/sound/events/gtk2-mate-events.soundlist

These should be OK in the main package:

%{_libdir}/matecomponent/monikers/libmoniker_extra_2.so
%{_libdir}/matecomponent/servers/MATE_Moniker_std.server


============================================================================

Please change the following:

%{_bindir}/* to:

%{_bindir}/mate-open

==============================================================================


Belongs in -devel (obviously)


%{_libdir}/pkgconfig/libmate-2.0.pc



======================

http://vicodan.fedorapeople.org/matespec/libmate.spec

Here's a copy of my spec file, (yeah I know it still needs work, but hope it
will help you.)
======================================


Also successful koji build on F17 both arches:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4408052

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]