https://bugzilla.redhat.com/show_bug.cgi?id=847604 --- Comment #1 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- Some suggestions: 1. Can you move %{_bindir}/matekbd-indicator-plugins-capplet %{_datadir}/applications/matekbd-indicator-plugins-capplet.desktop to an subpackage called capplet? Because capplet is the name of configuration elements in mate-control-center. So everyone knows it belongs there. 2. mateconf schemas need a spriplet section. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf 3. BR gtk+-devel means gtk-1.0, we don't need it. Adding libICE-devel is a good choice, see configure part. 4. Requires: %{name}-libs%{?_isa} = %{version}-%{release} under -devel is double call, because it's called under the main package. 5. no need for --add-only-show-in="X-MATE" in dektopfile installation for f18, because MATE is a valid entry for f18 desktopfile version. https://bugs.freedesktop.org/show_bug.cgi?id=52493 All done here. http://raveit65.fedorapeople.org/Mate-Desktop/f19/SPECS/libmatekbd.spec -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review