[Bug 849026] Review Request: jam-control - audioserver gui app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=849026

--- Comment #4 from Brendan Jones <brendan.jones.it@xxxxxxxxx> ---
Hi Jørn 

I think you may need Requires: pulseaudio-utils and Requires:
jack-audio-connection-kit as there's no way for RPM to pick up those runtime
dependencies due to os calls. Goes for anything else you don't explicity check
for the presence of in your program.

Spotted a typo builroot in one of your macros and you need to rename your
dektop file.

+ install -p -m 755 jackController.py jackDbusController.py jam-control.py
main_ui.py pulseController.py util.py
/home/bsjones/rpmbuild/BUILDROOT/jam-control-1.0-2.fc17.x86_64/usr/share/jam-control
+ mkdir -p
/home/bsjones/rpmbuild/BUILDROOT/jam-control-1.0-2.fc17.x86_64/usr/share/applications
+ desktop-file-install --vendor fedora --dir
/home/bsjones/rpmbuild/BUILDROOT/jam-control-1.0-2.fc17.x86_64/usr/share/applications
dist/jam-control.desktop
Error on file "dist/jam-control.desktop": No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.x4YfYe (%install)

Apart from that looks good

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]