https://bugzilla.redhat.com/show_bug.cgi?id=847712 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. So, looking at the main package, there's little risk of multilib conflicts (no binaries in particular), so I'm tempted to suggest dropping the -libs subpkg, and just fold all it's content (and scriptlets) into the main pkg (that's how gnome-menus is packaged, fwiw). 2. SHOULD move NOCONFIGURE=1 ./autogen.sh to %prep section 3. SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to decide where in the mate stack would best own this. checking /usr/share/gnome $ rpm -q -f /usr/share/gnome filesystem-3-2.fc17.x86_64 not helpful here. :( 4. SHOULD investigate if we need Requires: redhat-menus here somewhere. (ie, test running this and mate without redhat-menus installed, to see if there's any regressions or oddities) otherwise, naming: ok macros: ok scriptlets: ok sources: ok $ md5sum *.xz 540af0f76e2a28821cf4d32832c784d2 mate-menus-1.4.0.tar.xz licensing: ok items 1-4 aren't strictly blockers, but please do comment on or address them prior to doing any builds. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review