https://bugzilla.redhat.com/show_bug.cgi?id=847684 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Noticed some small errors in scriptlets now too (sorry): %pre %gconf_schema_prepare %{buildroot}/%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas %post -p /sbin/ldconfig /usr/bin/update-desktop-database &>/dev/null || : /bin/touch --no-create %{_datadir}/icons/mate &>/dev/null || : %gconf_schema_upgrade %{buildroot}/%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas %postun -p /sbin/ldconfig /usr/bin/update-desktop-database &>/dev/null || : %gconf_schema_remove %{buildroot}/%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor &>/dev/null || : should be (something like): %pre %gconf_schema_prepare %{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas %post /usr/bin/update-desktop-database &>/dev/null || : /bin/touch --no-create %{_datadir}/icons/mate &>/dev/null || : %gconf_schema_upgrade %{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas %postun /usr/bin/update-desktop-database &>/dev/null || : %gconf_schema_remove %{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor &>/dev/null || : please fix that prior to submitting any builds. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review