https://bugzilla.redhat.com/show_bug.cgi?id=847684 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok 1. SHOULD move NOCONFIGURE=1 ./autogen.sh to %setup section 2. MUST not use undefined macro %po_package, either define it or use %{name} instead 3. SHOULD add Provides: desktop-notification-daemon (assuming it provides dbus service org.freedesktop.Notifications like kde's knotify or gnome's notification-daemon) 4. SHOULD consider dropping -libs subpkg, I don't see any shared libraries in use here, so %files libs %{_libdir}/mate-notification-daemon/ could probably just be folded into the main package. licensing: ok sources: ok md5sum *.xz 83956e38caeec78634af379abc1b5787 mate-notification-daemon-1.4.0.tar.xz scriptlets: ok -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review