https://bugzilla.redhat.com/show_bug.cgi?id=847419 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. SHOULD remove BuildRequires: gtk+-devel it's not needed naming: ok licensing: ok sources: ok md5sum *.xz 7eccae36af5f9ee0e38a569fcd34e395 mate-polkit-1.4.0.tar.xz macros: ok scriptlets: mostly ok SHOULD: remove update-desktop-database &> /dev/null || : scriptlets, not needed here. 2. -devel MUST own %{_includedir}/polkit-gtk-mate-1/ (and polkitgtkmate subdir) imo, replace %{_includedir}/polkit-gtk-mate-1/polkitgtkmate/polkitgtkmate.h %{_includedir}/polkit-gtk-mate-1/polkitgtkmate/polkitgtkmatetypes.h %{_includedir}/polkit-gtk-mate-1/polkitgtkmate/polkitlockbutton.h with just %{_includedir}/polkit-gtk-mate-1/ 3. SHOULD drop dup'd %doc statement in -devel subpkg 4. SHOULD add Provides: PolicyKit-authentication-agent to match other policy kit providers (like gnome-polkit, polkit-kde) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review