https://bugzilla.redhat.com/show_bug.cgi?id=847697 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok $ md5sum *.xz 225a2ce7672c2a236c3b7d01da95af5a mate-backgrounds-1.4.0.tar.xz licensing 1 SHOULD remove BuildRequires: mate-conf-devel mate-corba-devel these aren't needed (builds ok for me without these) macros: mostly ok, except for: 2. SHOULD not use undefined macro po_package, change %find_lang %{po_package} --all-name ... %files -f %{po_package}.lang to %find_lang %{name} --all-name ... %files -f %{name}.lang 3. SHOULD: dir /usr/share/pixmaps/backgrounds seems unowned. mind either owning this here too, or consider if it's possible to move /usr/share/pixmaps/backgrounds/mate to /usr/share/backgrounds/mate to be closer to how gnome does things? (fwiw, kde uses /usr/share/wallpapers) scriptlets: ok (n/a) fairly good and simple, APPROVED. please address items 1-3 prior to doing any builds. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review