https://bugzilla.redhat.com/show_bug.cgi?id=845934 --- Comment #11 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. Note: wt-examples-3.2.2-1.p1.fc16.x86_64.rpm : /usr/lib64/Wt/examples/blog/BlogRSSFeed.h wt- ..... (OK. Those are in an package of example programs) [x]: MUST ldconfig called in %post and %postun if required. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Development (unversioned) .so files in -devel subpackage, if present. ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [!]: MUST Package contains no bundled libraries. Note: Please set cmake macro USE_SYSTEM_SQLITE3 to use system sqlite [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST %config files are marked noreplace or the reason is justified. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [?]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Note: Please check the attachment 'licensecheck-different.txt' for files with a different license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST No %config files under /usr. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [!]: MUST Package must own all directories that it creates. The following directories not owned: %{_datadir}/wt/ %{_datadir}/wt/resources/ [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [!]: MUST Requires correct, justified where necessary. Note: wt-dbo does not require wt. And so keep a copy of license in wt-dbo. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [?]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [?]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. Note: test requires Internet connection. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package contains no bundled libraries. Note: Please set cmake macro USE_SYSTEM_SQLITE3 to use system sqlite [!]: MUST License field in the package spec file matches the actual license. Note: Please check the attachment 'licensecheck-different.txt' for files with a different license. [!]: MUST Package must own all directories that it creates. The following directories not owned: %{_datadir}/wt/ %{_datadir}/wt/resources/ /var/spool/wt /var/spool/wt/run %{_includedir}/Wt/ %{_defaultdocdir}/%{name}-%{version}/images/ %{_defaultdocdir}/%{name}-%{version}/reference/ %{_defaultdocdir}/%{name}-%{version}/tutorial/ %{_defaultdocdir}/%{name}-%{version}/examples/ [!]: MUST Requires correct, justified where necessary. Note: * wt-dbo does not require wt. And so keep a copy of license in wt-dbo. * wt-devel should require wt-dbo-firebird Other personal checks: [!]: Is that necessary to rename %{_datadir}/Wt/ to %{_datadir}/wt/ ? [!]: %{_defaultdocdir}/%{name}-%{version}/main is a junk. [!]: Summary and description texts may be revised. My suggestions: * Summary for dbo: Wt::Dbo ORM library and the Sqlite backend * Desc for dbo: This package contains the Wt::Dbo Object-Relational Mapping library and the Sqlite3 backend of it. * Summary for dbo-postgres : PostgresSQL backend for the Wt::Dbo ORM library * Desc for dbo-postgres: This package contains the PostgresSQL backend for the Wt::Dbo ORM library * Summary for devel : 'Development files for Wt and Wt::Dbo' * Desc for devel: This package contains the files necessary to develop applications using the Wt toolkit and the Wt::Dbo ORM library. * Summary for examples may be just 'Examples for Wt'. * Desc for examples may be 'This package contains programming examples distributeed with official Wt release.' * Summary for doc may be 'Documents for the Wt toolkit' * Desc for doc may be 'This package contains the documents for Wt API and examples.' Requires -------- wt-devel-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): libwt.so.33()(64bit) libwtdbo.so.33()(64bit) libwtdbofirebird.so.33()(64bit) libwtdbopostgres.so.33()(64bit) libwtdbosqlite3.so.33()(64bit) libwtext.so.33()(64bit) libwtfcgi.so.33()(64bit) libwthttp.so.33()(64bit) libwttest.so.3()(64bit) wt(x86-64) = 3.2.2-1.p1.fc16 wt-dbo(x86-64) = 3.2.2-1.p1.fc16 wt-dbo-postgres(x86-64) = 3.2.2-1.p1.fc16 wt-debuginfo-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): wt-dbo-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig libboost_date_time-mt.so.1.47.0()(64bit) libboost_system-mt.so.1.47.0()(64bit) libboost_thread-mt.so.1.47.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwtdbo.so.33()(64bit) rtld(GNU_HASH) wt(x86-64) = 3.2.2-1.p1.fc16 wt-doc-3.2.2-1.p1.fc16.noarch.rpm (rpmlib, GLIBC filtered): wt-dbo-postgres-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig libboost_date_time-mt.so.1.47.0()(64bit) libboost_system-mt.so.1.47.0()(64bit) libboost_thread-mt.so.1.47.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpq.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libwtdbo.so.33()(64bit) rtld(GNU_HASH) wt(x86-64) = 3.2.2-1.p1.fc16 wt-dbo(x86-64) = 3.2.2-1.p1.fc16 wt-dbo-firebird-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig libboost_date_time-mt.so.1.47.0()(64bit) libboost_system-mt.so.1.47.0()(64bit) libboost_thread-mt.so.1.47.0()(64bit) libc.so.6()(64bit) libfbclient.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwtdbo.so.33()(64bit) rtld(GNU_HASH) wt(x86-64) = 3.2.2-1.p1.fc16 wt-dbo(x86-64) = 3.2.2-1.p1.fc16 wt-examples-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /bin/bash libGraphicsMagick.so.3()(64bit) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libboost_date_time-mt.so.1.47.0()(64bit) libboost_filesystem-mt.so.1.47.0()(64bit) libboost_program_options-mt.so.1.47.0()(64bit) libboost_random-mt.so.1.47.0()(64bit) libboost_regex-mt.so.1.47.0()(64bit) libboost_signals-mt.so.1.47.0()(64bit) libboost_system-mt.so.1.47.0()(64bit) libboost_thread-mt.so.1.47.0()(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libhpdf-2.1.0.so()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpng12.so.0()(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libwt.so.33()(64bit) libwtdbo.so.33()(64bit) libwtdbosqlite3.so.33()(64bit) libwtext.so.33()(64bit) libwthttp.so.33()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) wt(x86-64) = 3.2.2-1.p1.fc16 wt-dbo(x86-64) = 3.2.2-1.p1.fc16 wt-3.2.2-1.p1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig config(wt) = 3.2.2-1.p1.fc16 libGraphicsMagick.so.3()(64bit) libboost_date_time-mt.so.1.47.0()(64bit) libboost_filesystem-mt.so.1.47.0()(64bit) libboost_program_options-mt.so.1.47.0()(64bit) libboost_random-mt.so.1.47.0()(64bit) libboost_regex-mt.so.1.47.0()(64bit) libboost_signals-mt.so.1.47.0()(64bit) libboost_system-mt.so.1.47.0()(64bit) libboost_thread-mt.so.1.47.0()(64bit) libc.so.6()(64bit) libcrypto.so.10()(64bit) libfcgi++.so.0()(64bit) libfcgi.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libhpdf-2.1.0.so()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpng12.so.0()(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libwt.so.33()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- wt-devel-3.2.2-1.p1.fc16.x86_64.rpm: wt-devel = 3.2.2-1.p1.fc16 wt-devel(x86-64) = 3.2.2-1.p1.fc16 wt-debuginfo-3.2.2-1.p1.fc16.x86_64.rpm: wt-debuginfo = 3.2.2-1.p1.fc16 wt-debuginfo(x86-64) = 3.2.2-1.p1.fc16 wt-dbo-3.2.2-1.p1.fc16.x86_64.rpm: libwtdbo.so.33()(64bit) libwtdbosqlite3.so.33()(64bit) wt-dbo = 3.2.2-1.p1.fc16 wt-dbo(x86-64) = 3.2.2-1.p1.fc16 wt-doc-3.2.2-1.p1.fc16.noarch.rpm: wt-doc = 3.2.2-1.p1.fc16 wt-dbo-postgres-3.2.2-1.p1.fc16.x86_64.rpm: libwtdbopostgres.so.33()(64bit) wt-dbo-postgres = 3.2.2-1.p1.fc16 wt-dbo-postgres(x86-64) = 3.2.2-1.p1.fc16 wt-dbo-firebird-3.2.2-1.p1.fc16.x86_64.rpm: libwtdbofirebird.so.33()(64bit) wt-dbo-firebird = 3.2.2-1.p1.fc16 wt-dbo-firebird(x86-64) = 3.2.2-1.p1.fc16 wt-examples-3.2.2-1.p1.fc16.x86_64.rpm: wt-examples = 3.2.2-1.p1.fc16 wt-examples(x86-64) = 3.2.2-1.p1.fc16 wt-3.2.2-1.p1.fc16.x86_64.rpm: config(wt) = 3.2.2-1.p1.fc16 libwt.so.33()(64bit) libwtext.so.33()(64bit) libwtfcgi.so.33()(64bit) libwthttp.so.33()(64bit) libwttest.so.3()(64bit) wt = 3.2.2-1.p1.fc16 wt(x86-64) = 3.2.2-1.p1.fc16 MD5-sum check ------------- http://citylan.dl.sourceforge.net/project/witty/wt/3.2.2/wt-3.2.2-p1.tar.gz : MD5SUM this package : d436430a4f1ae5fbcf038e645e4b5260 MD5SUM upstream package : d436430a4f1ae5fbcf038e645e4b5260 SHA256SUM this package : 1610b1950eda3614a12e915f5968d7b8659eb17231622681c9a1eafc586c8f05 SHA256SUM upstream package: 1610b1950eda3614a12e915f5968d7b8659eb17231622681c9a1eafc586c8f05 Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09 Command line :/usr/bin/fedora-review -c --no-build -b 845934 External plugins: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review