Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtranslator - Gettext po file editor for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228208 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade@xxxxxxxxx 2007-02-12 00:20 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM + source files match upstream. 47531195b74b22a6284dad609377cbb0 gtranslator-1.1.7.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Dose owns the directories it creates. + no duplicates in %files. + Used Scrollkeeper-update scriptlet. + file permissions are appropriate. + Desktop file installed correctly. + GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review