https://bugzilla.redhat.com/show_bug.cgi?id=819338 Yanko Kaneti <yaneti@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |yaneti@xxxxxxxxxxx Flags| |fedora-review+ --- Comment #7 from Yanko Kaneti <yaneti@xxxxxxxxxxx> --- There might be an argument that setuid programs need special FESCO/security consideration before being accepted in the collection, but I think it should apply only to packages that are installed by default in some of the official spins. I am approving the package given that: - You'll fix the License: tag which currently says LGPL2v+, the source is GPLv2+ - You'll add a changelog - You'll fix the Source: line - s/2012.1/2012.2/ - You'll consider removing the rm -rf $RPM_BUILD_ROOT parts which are not needed in fedora or el6 Otherwise the source matches, the package builds in mock and seems to work, doesn't conflict with anything existing. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review