[Bug 844013] Review Request: openshift-origin-broker - OpenShift Origin broker components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844013

--- Comment #11 from Troy Dawson <tdawson@xxxxxxxxxx> ---
Spec URL:
http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-broker.spec
SRPM URL:
http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-broker-0.6.7-7.fc19.src.rpm

* permissions
- removed apache permissions
-- upstream says this should work but has not been completely tested.

* booleans - homedirs
- homedirs booleans - Yes, this is needed by openshift.
- httpd_run_stickshift - currently no response, but isn't a blocker

* booleans - reset them on each upgrade
- They are needed for openshift to run
- Is this a blocker?

* passenger selinux policy
- passenger in F17,f18 now has it's own policy.
-- removed all instances where we mess with passenger policy

* move config files in /etc/
- Upstream is aware of this and working towards it, not there yet
- Other openshift origin packages have this also
- Is this a blocker?

* redundant attr setting
- removed redundant attr settings

* selinux policy
- %ghost /usr/share/selinux/packages/%{name}/stickshift-broker.pp
- At this point I don't feel comfortable changing how they are doing their file
context.

* selinux side note
- contacted upstream about oddjob in the policy.
-- Will get an expert to go through the file and remove cruft (there is other
things that they think can be removed as well)
-- At this point they'd like to keep the cruft in so we don't accidentally
break anything.

*Macros for systemd
- I put in options so that it runs the macro's for F18+
- For F17- it uses the official commands for those
-- Side note: Right now, when the F18 macro expands, it is the exact 
same as what is in F17-.  It's somewhat expected, but it made it debuging
the %if command a little hard.

* Not start by default
- Changed that, using the recommended scriptlets for not starting by default

* Various cp should use -p
- Fixed

* extra mkdirs
- Removed extra and redundant mkdirs

* combine two lines into 1
- done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]