[Bug 848211] Review Request: mirall - owncloud desktop client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #3 from Gregor Tätzner <gregor@xxxxxxxxxx> ---
a more in deep look:

- the package contains desktop file icons - you must update the icon cache:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

- mirall.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmirallsync.so
/lib64/libQtTest.so.4...
-> again set -Wl,--as-needed

- upstream names the owncloud-client binary just owncloud. This is dumb and
much too generic. Maybe owncloud-sync-client would be more appropriate...be
creative but don't forget the desktop file

- actually this package ships two apps: a sync client and some kind of
installation tool. Would it make sense to split it up? I how far are those 2
apps related? Can you use one without the other?

- blocker:
mirall.x86_64: E: invalid-soname /usr/lib64/libmirallsync.so libmirallsync.so
The soname of the library is neither of the form lib<libname>.so.<major> or
lib<libname>-<major>.so.
mirall.x86_64: E: invalid-soname /usr/lib64/libowncloudsync.so
libowncloudsync.so
The soname of the library is neither of the form lib<libname>.so.<major> or
lib<libname>-<major>.so.

->I suppose these are not dev libs, so they must be versioned

- "- moved exclude.lst to /etc/mirall/"
Is it that easy? Are you sure the config file is still read by the client?
Oh, and mark it as %config

- BuildRequires:  inetd desktop-file-utils
Builds fine without inetd?

keep up :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]