https://bugzilla.redhat.com/show_bug.cgi?id=841713 Bastien Nocera <bnocera@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bnocera@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |bnocera@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Bastien Nocera <bnocera@xxxxxxxxxx> --- Package Review ============== Key: - = N/A x = Pass ! = Fail ==== C/C++ ==== [-]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Rpath absent or only used for internal libs. [-]: MUST Development (unversioned) .so files in -devel subpackage, if present. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [-]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST The spec file handles locales properly. [x]: MUST Package consistently uses macro. [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. gstreamer1-plugins-good.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-plugins-good.src: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gstreamer1-plugins-good.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-plugins-good.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gstreamer1-plugins-good-extras.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gstreamer1-plugins-good-extras.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 6 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD The placement of pkgconfig(.pc) files are correct. [-]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX is a working URL. [!]: SHOULD Spec use %global instead of %define. see https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define After that, looks good to push. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review