https://bugzilla.redhat.com/show_bug.cgi?id=848711 Jaroslav Reznik <jreznik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jaroslav Reznik <jreznik@xxxxxxxxxx> --- Name: ok Version: ok Summary: ok Group is not needed anymore, it's optional, see http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag License: ok URL: ok Sources: ok (md5sum 4dd5cd9a793a4cb16de2ca5bdfee7ca1) BuildRoot is not needed anymore, see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Requires: ok Provides: ok Description: ok Macros used consistently: ok Package builds: ok Docs: ok rpmlint spherical-cow-kde-theme-17.91.0-1.fc16.src.rpm spherical-cow-kde-theme.src:61: W: macro-in-comment %{buildroot} spherical-cow-kde-theme.src:61: W: macro-in-comment %{_kde4_appsdir} 1 packages and 0 specfiles checked; 0 errors, 2 warnings. The package is based on beefy-miracle-kde-theme (sed work), simple one. You can clean up SPEC according to current guidelines as it's going to the latest Fedora (no need to support EPEL). APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review