[Bug 848211] Review Request: mirall - owncloud desktop client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #1 from Gregor Tätzner <gregor@xxxxxxxxxx> ---
lets have a look:

- owncloud-client.desktop: error: value "Utility" for string list key
"Categories" in group "Desktop Entry" does not have a semicolon (';') as
trailing character

- BuildRequires:  oxygen-icon-theme
Really?

-Requires:       net-tools
-Requires:       iproute
I've never used mirall before, but this can't be right. iproute is a
replacement for net-tools. Why would you install both?

-again the changelog is a little bit borked: please insert the appropriate
versions

-%config %{_bindir}/../../etc/exclude.lst
just use configdir ;) Actually this file looks quite lost. Can you also put it
in /etc/mirall or rename it? and you want to use noreplace, too

-there are .so files in libdir: please call ldconfig in post and postun

-drop defattr

-BuildRequires:  qt4-devel >= 4.7
You can remove that check. even f16 ships qt 4.8

- I think you can also remove the first two lines in the description. This
"header" is not really necessary there

And it would be great if could you upgrade to the new mirall release

Thanks :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]