https://bugzilla.redhat.com/show_bug.cgi?id=845819 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Keep the Readme and License in the original location - I.e. refer to them as a %{gem_instdir}/LICENSE and %{gem_instdir}/README.md in the %files section and remove the "rm" * Test suite - Please consider running the test suite in the .%{gem_instdir}, which is convenient place to do so. The test folder in %{_builddir} is just remaining of gem repackaging. * Exclude %{gem_cache} - As always ... ;) * Use %{_bindir}/rspec - This could be used in place of BUildRequires: rubygem-rspec Nevertheless, non of these nits is blocker => APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review