Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cinepaint - CinePaint is a tool for manipulating images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225522 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-11 11:41 EST ------- (In reply to comment #3) > For the build error: > In file included from icc_common_funcs.c:38: > print_gimp.h:50:41: error: gutenprintui/gutenprintui.h: No such file or directory > ->> Need to enable BR gutenprint-devel... But it is already ! Can you figure > out why it did not download it ? Maybe a cache issue, does this file exist on > fc7 ? i wonder the path should be the same %{_includedir}/gutenprintui/*.h This is because: --------------------------------------------------- * Sat Jan 20 2007 Tim Waugh <twaugh@xxxxxxxxxx> 5.0.0-4 - Disable libgutenprintui (GTK+ 1.2 library). Build requires gtk2-devel, not gtk+-devel. --------------------------------------------------- So FE-devel gutenprint-devel does not have gtk+ compatible gutenprintui header files. So either: - rebuild this with gtk2 (is it possible?) - or ask gutenprint maintainer (Tim Waugh) to support GTK+. > * pkgconfig .pc files > Do i Really need a cinepaint-gtk-devel package? or use the > cinepaint-devel one ? > I may also need to sort headers... What do you mean? What I said is that "rewrite cinepaint-gtk.pc by using "Requires" properly". For example, libglade-2.0.pc (in libglade2-devel) contains: -------------------------------------------------- prefix=/usr exec_prefix=/usr libdir=/usr/lib includedir=/usr/include moduledir=${libdir}/libglade/2.0 Name: Libglade Description: a library for dynamically loading GLADE interface files Version: 2.6.0 Requires: gtk+-2.0 libxml-2.0 <- Please write like this!! Libs: -L${libdir} -lglade-2.0 Cflags: -I${includedir}/libglade-2.0 -------------------------------------------------- > > * cinepaint.m4 The content of this file produce errors when trying to rpmbuild > package that run aclocal on my system...There is a need to check this file for > its content! ? What I meant is - This file should be moved to -devel package - Add "Requires: automake" to -devel package > * BR : It requires gtk+-devel (which bring glib-devel) What I said is why do you use gtk+-devel and glib*2*-devel (not glib-devel)? > > * Searching which BR is needed for this : > checking for Python library... Not found > ->> OK for an unknow reason, it seems to BR libgcj-devel! This is python!! Not java. Only you need is python-devel. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review