https://bugzilla.redhat.com/show_bug.cgi?id=847457 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Version 1.4.0.2 available - Is there any particular reason why not package the most recent version? * Use %global in place of %define [1] * Do not depend on rubygem(hoe) - This is just development dependency. You don't need it for runtime and there is only tiny chance that you would need it for build time. * Drop s.cert_chain in .gemspec - I would say that better than changing the s.cert_chain would be to fallback to default, i.e. drop the line: sed -i '/s.cert_chain = nil/ d' %{gem_name}.gemspec * Leave the History.txt Install.txt Licence.txt Readme.txt Manifest.txt on original place - Please consider to keep the files on the original place. I am not sure what would be the benefit to move them into different place * Move documentation into -doc subapackage - Please consider move of History.txt, Install.txt, Readme.txt and Manifest.txt files into -doc subpackage, since they are not required by runtime. * Exclude %{gem_cache} - We discussed it before in different review, but I'd like to mention it here, although I don't expect you will do that ;) * export CONFIGURE_ARGS not needed - Since this is not binary gem, the export CONFIGURE_ARGS could be omitted. * Mark %{gem_docdir} as as %doc * Please fix the executable bit - rpmlint complains about following files: rubygem-transaction-simple-doc.noarch: E: non-executable-script /usr/share/gems/gems/transaction-simple-1.4.0/test/test_transaction_simple.rb 0644L /usr/bin/env rubygem-transaction-simple-doc.noarch: E: non-executable-script /usr/share/gems/gems/transaction-simple-1.4.0/test/test_all.rb 0644L /usr/bin/env rubygem-transaction-simple-doc.noarch: E: non-executable-script /usr/share/gems/gems/transaction-simple-1.4.0/test/test_transaction_simple_group.rb 0644L /usr/bin/env rubygem-transaction-simple-doc.noarch: E: non-executable-script /usr/share/gems/gems/transaction-simple-1.4.0/test/test_transaction_simple_threadsafe.rb 0644L /usr/bin/env rubygem-transaction-simple-doc.noarch: E: non-executable-script /usr/share/gems/gems/transaction-simple-1.4.0/test/test_broken_graph.rb 0644L /usr/bin/env rubygem-transaction-simple-doc.noarch: E: non-executable-script /usr/share/gems/gems/transaction-simple-1.4.0/Rakefile 0644L /usr/bin/env [1] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review