https://bugzilla.redhat.com/show_bug.cgi?id=847777 --- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- - BuildRequires: "python-setuptools-devel" should be just "python-setuptools". - Your Requies: python-lxml should specify the version as in setup.py (>= 2.2.8). - Requires: python is useless, because the automatic dependency processor will pick that dependency up and specify it better: $ rpm -q -p --requires strata-sdk-1.0.1-0.fc19.noarch.rpm ... python(abi) = 2.7 ... So please drop the Requires: python line. - Is there a specific reason to run build and install the way you do and not doing just "python setup.py [build|install]"? If not, please use the standard way, as the current state is somehow confusing. - When there are tests present in the package, it is a good practice to run them in the %check section of the specfile. This ensures that the package works as deployed from source. Please do this. - The first release should be 1, not 0. - I'm not sure about the URL you provide. Typically, it should point to a page with some kind of the information about the project - I found no information about strata-sdk at your URL. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review