https://bugzilla.redhat.com/show_bug.cgi?id=848043 Brenton Leanhardt <bleanhar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bleanhar@xxxxxxxxxx --- Comment #1 from Brenton Leanhardt <bleanhar@xxxxxxxxxx> --- Hi, I would like to perform an informal review as part of my sponsorship process. You should use the dist tag in your release: https://fedoraproject.org/wiki/Packaging/DistTag The Buildroot tag should not be used: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Also, these lines are not needed: [ "%{buildroot}" != "/" ] && rm -rf %{buildroot} They are essentially doing the same thing as the clean tag, which is also not needed: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review