https://bugzilla.redhat.com/show_bug.cgi?id=847504 Brenton Leanhardt <bleanhar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bleanhar@xxxxxxxxxx --- Comment #1 from Brenton Leanhardt <bleanhar@xxxxxxxxxx> --- Hi Miroslav, I would like to perform an informal review as part of my sponsorship process. The main issue fedora-review found was: [!]: EXTRA Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). It just looks like the specfile in the SRPM is missing your latest chmod fix. On a related not it would be great to create a bug upstream about the executable bit being set on scoped_search.rb and add a link in this specfile. That way it can be removed when it's finally fixed. [!]: MUST Gem package must exclude cached Gem. See: http://fedoraproject.org/wiki/Packaging:Ruby Other suggestions are: [!]: SHOULD Test suite of the library should be run. For what it's worth I'm running fedora-review-0.2.2-1 from the fedora testing repo (there was a bugfix I needed). Here's the full output: Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [!]: EXTRA Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). [ ]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [ ]: MUST Package contains no bundled libraries. [ ]: MUST Changelog in prescribed format. [ ]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package contains desktop file if it is a GUI application. [ ]: MUST Development files must be in a -devel package [ ]: MUST Package requires other packages for directories it uses. [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [ ]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: MUST License file installed when any subpackage combination is installed. [ ]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [ ]: MUST Package is named according to the Package Naming Guidelines. [ ]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. [ ]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: MUST Package must own all directories that it creates. [ ]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [ ]: MUST Package is not relocatable. [ ]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL5 is required [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: SHOULD Package functions as described. [ ]: SHOULD Latest version is packaged. [ ]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (scoped_search-2.3.7.gem) [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. ==== Language ==== [x]: MUST Gem package must not define a non-gem subpackage [!]: MUST Gem package must exclude cached Gem. [ ]: MUST Platform dependent files must all go under %{gem_extdir}, platform independent under %{gem_dir}. [x]: MUST Gem package is named rubygem-%{gem_name} [x]: MUST Package contains BuildRequires: rubygems-devel. [x]: MUST Gem package must define %{gem_name} macro. [x]: MUST Pure Ruby package must be built as noarch [x]: MUST Package contains Requires: ruby(abi). [!]: SHOULD Specfile should utilize macros from rubygem-devel package. Note: The specfile doesn't use these macros: %exclude %{gem_cache}, %{gem_libdir} [x]: SHOULD Test suite should not be run by rake. [!]: SHOULD Test suite of the library should be run. Issues: [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames [!]: MUST Gem package must exclude cached Gem. See: http://fedoraproject.org/wiki/Packaging:Ruby Rpmlint ------- Checking: rubygem-scoped_search-2.3.7-5.fc16.noarch.rpm rubygem-scoped_search-2.3.7-5.fc16.src.rpm rubygem-scoped_search-doc-2.3.7-5.fc16.noarch.rpm rubygem-scoped_search.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases rubygem-scoped_search.noarch: E: script-without-shebang /usr/lib/ruby/gems/1.8/gems/scoped_search-2.3.7/lib/scoped_search.rb rubygem-scoped_search.src: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/textual%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/infix%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/datetime%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/prefix%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/register_named_scope%21-i.yaml %21 rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/date%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/numerical%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/temporal%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/eql%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/set%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/%5b%5d-i.yaml %5b rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/%5b%5d-i.yaml %5d rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/LeafNode/eql%3f-i.yaml %3f 3 packages and 0 specfiles checked; 1 errors, 15 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-scoped_search-doc rubygem-scoped_search-doc.noarch: I: enchant-dictionary-not-found en_US rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/textual%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/infix%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/datetime%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/prefix%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/register_named_scope%21-i.yaml %21 rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/date%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/numerical%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/temporal%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/eql%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/Definition/Field/set%3f-i.yaml %3f rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/%5b%5d-i.yaml %5b rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/OperatorNode/%5b%5d-i.yaml %5d rubygem-scoped_search-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/scoped_search-2.3.7/ri/ScopedSearch/QueryLanguage/AST/LeafNode/eql%3f-i.yaml %3f 1 packages and 0 specfiles checked; 0 errors, 13 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/rpmbuild/rpmbuild/SPECS/rubygem-scoped_search.spec 2012-08-12 07:45:51.000000000 -0400 +++ /home/rpmbuild/rpmbuild/SPECS/rubygem-scoped_search/srpm-unpacked/rubygem-scoped_search.spec 2012-08-14 09:40:13.589053075 -0400 @@ -12,5 +12,5 @@ Version: 2.3.7 -Release: 6%{dist} +Release: 5%{dist} Group: Development/Languages License: MIT @@ -46,5 +46,5 @@ suitable to quickly add basic search functionality to your application with little hassle. On the other hand, -it may not be the best choice if it is going to be used on very large data sets +it may not be the best choice if it is going to be used on very large datasets or by a large user base. @@ -81,5 +81,4 @@ cp -a ./%{gem_dir}/* %{buildroot}%{gem_dir}/ mv %{buildroot}%{gem_instdir}/{LICENSE,README.rdoc} ./ -chmod a-x %{buildroot}%{gem_instdir}/lib/scoped_search.rb %files @@ -101,8 +100,4 @@ %changelog -* Sun Aug 12 2012 Miroslav Suchý <msuchy@xxxxxxxxxx> 2.3.7-6 -- fix spelling error (msuchy@xxxxxxxxxx) -- module scoped_search.rb should not be executable (msuchy@xxxxxxxxxx) - * Sun Aug 12 2012 Miroslav Suchý <msuchy@xxxxxxxxxx> 2.3.7-5 - buildroot is not needed (msuchy@xxxxxxxxxx) Requires -------- rubygem-scoped_search-2.3.7-5.fc16.noarch.rpm (rpmlib, GLIBC filtered): ruby(abi) = 1.8 rubygem-activerecord >= 2.1.0 rubygems rubygem-scoped_search-doc-2.3.7-5.fc16.noarch.rpm (rpmlib, GLIBC filtered): rubygem-scoped_search = 2.3.7-5.fc16 Provides -------- rubygem-scoped_search-2.3.7-5.fc16.noarch.rpm: rubygem(scoped_search) = 2.3.7 rubygem-scoped_search = 2.3.7-5.fc16 rubygem-scoped_search-doc-2.3.7-5.fc16.noarch.rpm: rubygem-scoped_search-doc = 2.3.7-5.fc16 MD5-sum check ------------- https://rubygems.org/downloads/scoped_search-2.3.7.gem : CHECKSUM(SHA256) this package : aa90bdb48c2a33321b90368a5634ed9a35f0cf385b147557a2bce77eb35e04c4 CHECKSUM(SHA256) upstream package : aa90bdb48c2a33321b90368a5634ed9a35f0cf385b147557a2bce77eb35e04c4 Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09 Command line :/usr/bin/fedora-review -n rubygem-scoped_search External plugins: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review