Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: squirrelmail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224245 ------- Additional Comments From tokul@xxxxxxxxxxxxxxxxxxxxx 2007-02-11 02:50 EST ------- (In reply to comment #0) > Requesting review in preparation for the Fedora merge. This package is in a horrible, horrible mess, with language specific patches (more yet coming...) and a mass encoding change. Fedora needs some serious help in merging these things upstream, and convincing upstream to handle the l10n encodings in a non-braindead way so we don't have to ship with these horrible ugly hacks. > When was the last time you have submitted your SquirrelMail patches to upstream? I think Fedora SquirrelMail rpm contains several patches that are never submitted to upstream. And you don't listen when upstream developer warns you about uninitialized variables in your patches. You assume that #195639 is specific to Japanese, but same thing happens in Chinese and Korean. #195639 issue happens only when translation uses euc or gb or big5 character sets. rawurlencode is needed, if CJK translation is used in utf-8. You keep CJK translations in their original encodings, because "UTF-8 is unrealistic". I think you haven't checked SquirrelMail extra decoding library functions. euc-kr, gb2312 and big5 translations are unrealistic in RedHat, because SquirrelMail does not support these charsets in encoding functions and RedHat does not enable PHP extensions (#106755) that allow to implement CJK encoding functions. If encoding functions are not implemented, you must write more XTRA_CODE hacks for Chinese and Korean, because without those hacks replies to gb2312-hz, iso-2022 and utf8 emails are broken in gb2312/big5 Chinese and euc-kr Korean. UTF-8 is unrealistic only when you want to accept Chinese emails with mime formating violations. You ask to push patch to upstream in #209105, when in fact issue is caused by smart B encoding in some other product. SquirrelMail does not make that type of encoding decisions in B encoding. > Squirrelmail is a terrible IMAP webmail client that hasn't improved... And these words are coming from a person that does not cooperate with upstream developers and hasn't moved a finger to push Fedora fixes to upstream. http://search.gmane.org/search.php?query=warren+togami&author=&group=gmane.mail.squirrelmail.user&sort=date&submit=submit http://search.gmane.org/search.php?query=warren+togami&author=&group=gmane.mail.squirrelmail.internationalization&sort=date&submit=submit http://search.gmane.org/search.php?query=warren+togami&author=&group=gmane.mail.squirrelmail.devel&sort=date&submit=submit http://search.gmane.org/search.php?query=warren+togami&author=&group=gmane.mail.squirrelmail.plugins&sort=date&submit=submit One email about broken patches and one email by other person related to lack of mbstring support in older redhat packages. Zero emails about #196017, #195639, #195452, #194457, #194598. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review