https://bugzilla.redhat.com/show_bug.cgi?id=847952 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to comment #3) > Hi Peter, > > 1. COPYING is included in the package, I think by the octave macros: > [ankur@ankur SRPMS]$ rpm -qpl > /var/lib/mock/fedora-rawhide-x86_64/result/octave-nnet-0.1.13-2.fc19.noarch. > rpm | egrep COPY > /usr/share/octave/packages/nnet-0.1.13/packinfo/COPYING I am aware of it but this is a "MUST" rule - so please add another one copy as %doc. * https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text "If the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc." > 2. The .autoload file looks like it's included. I looked at other octave > modules already in fedora and they all seem to include it: > [root@ankur ~]# repoquery -l octave-* | egrep autoload > /usr/share/octave/packages/audio-1.1.4/packinfo/.autoload > /usr/share/octave/packages/communications-1.1.0/packinfo/.autoload > /usr/share/octave/packages/control-2.2.4/packinfo/.autoload > /usr/share/octave/packages/gsl-1.0.8/packinfo/.autoload > /usr/share/octave/packages/image-1.0.15/packinfo/.autoload > /usr/share/octave/packages/miscellaneous-1.0.11/packinfo/.autoload > /usr/share/octave/packages/octcdf-1.1.4/packinfo/.autoload > /usr/share/octave/packages/optim-1.0.17/packinfo/.autoload > /usr/share/octave/packages/quaternion-1.0.0/packinfo/.autoload > /usr/share/octave/packages/signal-1.1.2/packinfo/.autoload > /usr/share/octave/packages/struct-1.0.9/packinfo/.autoload > /usr/share/octave/packages/symbolic-1.1.0/packinfo/.autoload > [root@ankur ~]# Ok, good then. > 3. I've removed the perl file. It looks like it's something upstream uses to > generate TeX sources and isn't required for the fedora package. Ok. > 4. I corrected the source tar's permissions also to get rid of the rpmlint > warning: > [ankur@ankur SRPMS]$ rpmlint octave-nnet-0.1.13-2.fc17.src.rpm > /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/octave-nnet.spec > octave-nnet.src: W: spelling-error Summary(en_US) multi -> mulch, mufti > octave-nnet.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti > octave-nnet.noarch: W: obsolete-not-provided octave-forge > octave-nnet.noarch: W: hidden-file-or-dir > /usr/share/octave/packages/nnet-0.1.13/packinfo/.autoload > octave-nnet.noarch: E: zero-length > /usr/share/octave/packages/nnet-0.1.13/packinfo/.autoload > octave-nnet.noarch: W: dangerous-command-in-%preun rm > octave-nnet.src: W: spelling-error Summary(en_US) multi -> mulch, mufti > 3 packages and 1 specfiles checked; 1 errors, 6 warnings. > [ankur@ankur SRPMS]$ Ok. good. I don't see any other issues (assuming that you will fix licensing issue shortly) so this package is APPROVED. PS. it would be great if you will review this one in return: * https://bugzilla.redhat.com/show_bug.cgi?id=652682 It's rather messy and probably has a lot of room for improvement - sorry for that. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review