[Bug 845934] Review Request: witty - C++ library for developing web applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=845934

Vasiliy Glazov <vascom2@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vascom2@xxxxxxxxx

--- Comment #4 from Vasiliy Glazov <vascom2@xxxxxxxxx> ---
I return and ready to work.

1. First of all, we must understand name of last sources:
3.2.2-p1    Jul 27, 2012    Wt 3.2.2 patch-level 1

It pre-release or post-release of 3.2.2? Then package name should be
if pre: wt-3.2.2-0.1.p1
if post: wt-3.2.2-2.p1
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release

2. I think subpackages -devel and -examples can be merged. Because all header
files should be in devel. And install -examples without -devel does not make
sense.
3. Remove all defattr... from %files section.
4. Remove rm -rf $RPM_BUILD_ROOT from %install section.
5. Why you convert absolute symlink to relative? rpmlint warning on it.

Please check all packages (and srpm and spec) with rpmlint tool.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]