[Bug 838239] Review Request: rubygem-ghost - Allows you to create, list, and modify local hostnames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=838239

--- Comment #1 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
[X]  rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1] 

mcpierce@mcpierce-laptop:ghost-0.3.0  $ rpmlint
rubygem-ghost-0.3.0-1.fc17.src.rpm 
(none): E: no installed packages by name rubygem-ghost-0.3.0-1.fc17.src.rpm
0 packages and 0 specfiles checked; 0 errors, 0 warnings.


[X]  The package must be named according to the Package Naming Guidelines .
[X]  The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] . 
[X]  The package must meet the Packaging Guidelines .
[X]  The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
[X]  The License field in the package spec file must match the actual license.
[3]
[X]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
[X]  The spec file must be written in American English. [5]
[X]  The spec file for the package MUST be legible. [6]
[X]  The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
[X]  The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
[X]  All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[X]  The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[X]  Packages must NOT bundle copies of system libraries.[11]
[X]  A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]
[X]  A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
[X]  Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]
[X]  Each package must consistently use macros. [16]
[X]  The package must contain code, or permissable content. [17]
[1]  Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
[X]  If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. [18]
[2]  Development files must be in a -devel package. [20]
[2]  In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]
[X]  Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. [23]
[X]  All filenames in rpm packages must be valid UTF-8. [24]

[X]  Each Ruby package must indicate the Ruby ABI version it depends on.
[X]  Packages that contain Ruby Gems must be called rubygem-%{gem_name}.
[X]  Pure Ruby packages must be built as noarch packages.
[2]  If there is test suite available for the package (even separately, for
example not included in the gem but available in the upstream repository), it
should be run in %check.

NOTES:
 [1] The ri docs should be moved to a -doc package. [NONBLOCKER]
 [2] The Rakefile should either be removed or else included in a -devel
package. [BLOCKER]
 [3] The lines to delete an existing $RPM_BUILD_ROOT and create a new one
should be deleted.
     * Instead, please use the example %prep section from
http://fedoraproject.org/wiki/Packaging:Ruby [BLOCKER]
     * Additionally, the %clean section ought to be removed as well.
[NONBLOCKER]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]