[Bug 841648] Package Rename Review Request: rubygem-qpid_messaging - Ruby bindings for the Qpid messaging framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=841648

--- Comment #7 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
(In reply to comment #5)
<snip>
> Issues:
> 
> 1. RPMLint warnings all look okay. If you want to reduce warnings you can
> take out the commented code, though not required.
> 
> 2. "gem install" portion of the spec file should probably be under the
> %build section instead of the %prep section. This is shown on the ruby
> guidelines page: http://fedoraproject.org/wiki/Packaging:Ruby#.25build
> 
> 3. Unable to build on Rawhide/F18 due to a missing dependency. It looks like
> the qpid-cpp-client-devel package you require needs boost 1.48, but Rawhide
> now has 1.50. Whoever maintains qpid-cpp-client will need to fix that before
> your package will build.

I'm the package maintainer there as well. I'm holding off on doing an update of
0.16 in Rawhide since we're preparing for the 0.18 release in the near future.
But I suppose I could go ahead and fix the 0.16 build sooner instead.

> Please address issue #2 and I'll take another look at your package.

I've moved the gem install portion to the %build section per review.

Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_messaging.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-qpid_messaging-0.16.0-1.2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]