[Bug 846928] Review Request: python-walkdir - Python module to manipulate and filter os.walk() style iteration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=846928

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-
+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4370968

+ rpmlint on rpms gave
python-walkdir.src: W: spelling-error Summary(en_US) os -> OS, och, so
python-walkdir.src: W: spelling-error %description -l en_US os -> OS, och, so
python-walkdir.noarch: W: spelling-error Summary(en_US) os -> OS, och, so
python-walkdir.noarch: W: spelling-error %description -l en_US os -> OS, och,
so
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Source verified with upstream as sha56sum
b68b22f78b3412749a1a0f7efff477ab002f05a0d1ed26fb69e4a42038361736 
walkdir-0.3.tar.gz
b68b22f78b3412749a1a0f7efff477ab002f05a0d1ed26fb69e4a42038361736 
../SOURCES/walkdir-0.3.tar.gz

+ License is valid and is BSD.

Suggestions:
1) Replace %define with %global

2) If package is only for Fedora then you can remove buildroot, cleaning of
buildroot in %install, %clean section and defattr(-,root,root,-)

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]