[Bug 847345] Review Request: libmatecanvas - MateCanvas widget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847345

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
BuildRequires to drop:

libtool (needed by mate-common)
gettext (needed by intltool)

The gail-devel package is deprecated:
https://admin.fedoraproject.org/pkgdb/acls/name/gail

If it is really needed for building this package, we have to look for a
replacement. But if I remember well, gail has been swallowed by Gtk some time
ago. Perhaps an artifact from the early years of Gnome...?


Requires: %{name} = %{version}-%{release}
has to be
Requires: %{name}%{?_isa} = %{version}-%{release}


# for /usr/share/gtk-doc/html
Requires: gtk-doc

Not needed. Because libmatecanvas doesn't need gtk-doc at runtime, you may
co-own the appropriate folder in %files:

%{_datadir}/gtk-doc

It's one of the most used exceptions regarding file ownerships, and it affects
currently more than hundred packages in Fedora, or even more.


Use the general description for the -devel package:

The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.


The %defattr lines in %files are obsolete. You might drop them, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]