[Bug 785371] Review request: speed-dreams - The Open Racing Car Simulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=785371

Jeremy Newton <alexjnewt@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #45 from Jeremy Newton <alexjnewt@xxxxxxxxxxx> ---
It seems it builds just fine under Mock. Test cases, Fedora 16 32bit and Fedora
17 64bit were both successful.

It seems I missed the rm -rf docs; mkdir docs part in the spec file, so please
ignore my previous statements about documentation save for the rpmlint manpage
warning.

Everything seems good, though I still think the extra docs folder is sloppy;
The extra docs folder should be removed, as it's completely unnecessary.

This can be quickly fixed by changing the $doc line to:
%doc *.xml *.txt

Fix this minor issue and I SHOULD be able to approve this for you.

Also it maybe a good idea to leave a comment above the rm -rf docs line stating
why it needs to be removed (I would assume it's because the documentation is
depreciated, which should be reported upstream at least)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]