[Bug 823682] Review Request: gnome-shell-theme-adwaita - The Adwaita gnome-shell theme created by half_left

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=823682

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Some comments:

Themes for gnome-shell are not intended to be packaged for EPEL 5. That's why
you have to remove the BuildRoot definition, the %clean section and the
%defattr line from %files.

The folder defined in the %theme macro (for LICENSE) is already owned by
gnome-themes-standard, also the folder %{_datadir}/themes/%{theme}. Well, we
could decide to let co-own your package this folder, because the gnome-shell
theme would even work without the Adwaita gtk themes. But in my mind it would
be better to drop the ownership and add "Requires: gnome-themes-standard".
Logically, the Adwaita shell theme is a useful add-on to the other Adwaita
stuff and shouldn't be recognized as completely independent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]