Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-10 11:05 EST ------- Well, for 0.5.4-1: * BuildRequires/Requires: - This is gtk2 application and gtk+ is not necessary. - Also, libglade is not needed. - pkgconfig for BuildRequires is redundant as gtk2-devel requires (and should require) pkgconfig. - gtk2-devel for BuildRequires is redundant. libglade2-devel requires gtk2-devel. * Source vs using echo - Personally, I don't like to use "echo ???? >> file" because: - it may update timestamp of the file unnecessarily. - this makes the spec file larger. Rather I like to make a file and include it as sources. * Desktop file - Category ------------------------------------------------------------- --add-category X-Fedora \ ------------------------------------------------------------- This category is deprecated and should be removed. - Icon ------------------------------------------------------------- Icon=gnome-dev-harddisk ------------------------------------------------------------- aracarte shows that this is taken from /usr/share/icons/Bluecurve/48x48/devices/gnome-dev-harddisk.png, so adding "Requires: redhat-artwork" is preferable, IMO (on FC-devel. on FC-6, this may differs). * soft linking - soft linking should be relative. ------------------------------------------------------------- ln -s /%{_bindir}/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name} ------------------------------------------------------------- should be: ------------------------------------------------------------- ln -s consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name} ------------------------------------------------------------- * Timestamps - Keep timestamps on text files, for example, .fdi files in /usr/share/ntfs-config/. Perhaps ------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" ------------------------------------------------------------- will work (check this). * Documentation - Please add the following documents. ------------------------------------------------------------- README TODO ------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review