[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844080

--- Comment #14 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> ---
In relation to your last uploaded version 1.4.0-3 some suggestions.

1. Why you use pkgconfig as Requires and BuildRequires ?
Those are sufficient.
BuildRequires:     libxml2-devel
BuildRequires:     mate-corba-devel
BuildRequires:  mate-common
BuildRequires:  flex
BuildRequires:  popt-devel
BuildRequires:  byacc

2. You don't need BuildRequires in -devel again.

3. We need a provide under main package for future packages.
Provides:         libmatecomponent-activation = %{version}-%{release}

and under -devel
Provides:         libmatecomponent-activation-devel = %{version}-%{release}

repoquery --whatrequires libmatecomponent-activation
python-mate-matecomponent-0:1.2.0-3.fc16.i686
python-mate-matecomponent-0:1.2.0-3.fc16.x86_64
python-mate-matecomponent-0:1.4.0-1.fc16.i686
python-mate-matecomponent-0:1.4.0-1.fc16.x86_64

4. use --disable-static as configure flag

5. libmatecomponent x86_64  needs to own the directory that i686 packages
install into.
For this we need the libmatecomponent-multishlib.patch, required for multilib
installs  /usr/lib/matecomponent/servers
and in spec file under %install those lines.

for serverfile in $RPM_BUILD_ROOT%{_libdir}/matecomponent/servers/*.server; do
    sed -i -e 's|location *= *"/usr/lib\(64\)*/|location="/usr/$LIB/|'
$serverfile
done

# noarch packages install to /usr/lib/matecomponent/servers
mkdir -p $RPM_BUILD_ROOT%{_prefix}/lib/matecomponent/servers


Those actions and the patch creates two directories on x86_64
/usr/lib/matecomponent/servers/ and /usr/lib64/matecomponent/servers/

All suggestions are very recommended to do.
Here is all done
Spec:
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/libmatecomponent.spec
Patch:
http://raveit65.fedorapeople.org/Mate-Desktop/patches/libmatecomponent-multishlib.patch

PS: pls upload actual sources before you asked for e reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]