[Bug 847268] Review Request: girara - Simple user interface library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=847268

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Some initial comments:

If you don't want to provide your package for EPEL5 and older, you might drop
the following:

- BuildRoot:
- the %clean section
- the %defattr lines in %files

You are using the %find_lang macro, that's why this line is unneeded:
%{_datarootdir}/locale/*/LC_MESSAGES/*.mo
The macros is searching for translation files automatically and puts them in
the right places.


The usual description for -devel packages is:

The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.

This comes from rpmdev-newspec, if you are creating a library spec with the "-t
lib" option.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]