[Bug 844192] Review Request: gksu-polkit - Command line utility to run programs as root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844192

--- Comment #7 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
> This looks pretty good for approval however please correct the following:
> 
> 
> $ rpmlint gksu-polkit-libs-0.0.3-2.fc17.x86_64.rpm 
> gksu-polkit-libs.x86_64: E: postun-without-ldconfig
> /usr/lib64/libgksu-polkit.so.0.0.1
> gksu-polkit-libs.x86_64: E: non-empty-%postun /sbin/ldconfig
> 1 packages and 0 specfiles checked; 2 errors, 0 warnings.
> 
Done. See the new files below. I've removed file_lang for now to avoid these
> 
> $ rpmlint gksu-polkit-libs-devel-0.0.3-2.fc17.x86_64.rpm 
> gksu-polkit-libs-devel.x86_64: W: invalid-url URL:
> http://live.gnome.org/gksu <urlopen error [Errno -2] Name or service not
> known>
> 
I didn't have any problems yet to reach this URL, should be a problem at your
side (temporarily bad network connection?).

> Please open or reference a bug addressing the following:
> 
> 
> gksu-polkit-libs-devel.x86_64: E: incorrect-fsf-address
> /usr/include/gksu-polkit/gksu-process.h
> gksu-polkit-libs-devel.x86_64: E: incorrect-fsf-address
> /usr/include/gksu-polkit/gksu-polkit.h

There's no Bugzilla for it, unless I would be a Debian user and could file a
bug directly from the system. Doesn't matter, I've mailed the developer
directly (kov@xxxxxxxxxx), while CC'ing Jeremy:

> Hi Gustavo,

> while packaging gksu-polkit for Fedora, I've detected some wrong FSF
> addresses in the source files:


> /common/gksu-environment.c
> /common/gksu-write-queue.c
> /common/gksu-write-queue.h
> /gksu/gksu-polkit.c
> /libgksu/gksu-process.c
> /libgksu/gksu-process.h
> /libgksu/gksu-process-error.h
> /mechanism/gksu-controller.c
> /mechanism/gksu-controller.h
> /mechanism/gksu-error.h
> /mechanism/gksu-server.c
> /mechanism/gksu-server.h
> /mechanism/main.c

> I've found them by using the validation tool "rpmlint" in the v0.0.3
> files. Please consider to change the address to the current one in
> future releases:

> Free Software Foundation
> 51 Franklin Street, Fifth Floor
> Boston, MA 02110-1301
> USA


> Best Regards

> Mario


New files:

Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/gksu-polkit.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/gksu-polkit-0.0.3-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]