https://bugzilla.redhat.com/show_bug.cgi?id=846660 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- well, some initial comments anyway: 1. MUST remove explicit Requires: libmatenotify that dep should get pulled in automatically 2. MUST fix dir ownership, replace %{_datadir}/mate/* %{_datadir}/matedialog/* with %{_datadir}/mate/ %{_datadir}/matedialog/ unless there's some better place lower in the stack to own either of these? 3. SHOULD move NOCONFIGURE=1 ./autogen.sh to %setup section 4. SHOULD issue a verbose build, replace make %{?_smp_mflags} with make %{?_smp_mflags} V=1 5. SHOULD(?) remove Requires: scrollkeeper Unless there's some reason to keep it, if so, please document in the .spec why 6. SHOULD remove from %description: "Fork of gdialog." I personally don't think this adds anything of value (end users shouldn't care about it's origins) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review