https://bugzilla.redhat.com/show_bug.cgi?id=760696 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |vondruch@xxxxxxxxxx Flags| |fedora-review+ --- Comment #20 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #19) > - Updated to latest version - 1.6.4 Thanks > - Went through tests. Only run the tests that do not require a mongodb > server to be running. Sounds good. > - Trimmed down the BuildRequires needed for tests > -- rubygem-bson_ext - only optional > -- rubygem-json - pulled in by rubygem-minitest > - Added BuildRequires that were missing > -- rubygem-test-unit Actually the test-unit is probably not required. I opened this [1] issue while updating bson. Anyway, use test-unit or minitest, but do not require both. The minitest should not be needed now by my testing. And I have another issues here: * %{gem_instdir}/docs should be marked as %doc * Keep %doc %{gem_instdir}/LICENSE.txt in the main package - And completely remove %doc LICENSE.txt Nevertheless, the package looks good to me. Since nobody else officialy claimed it for a review, I am claiming it now and APPROVE. Please fix the remaining issues before commit. [1] https://jira.mongodb.org/browse/RUBY-465 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review